Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support new API routes for edit profile social media #216

Merged
merged 5 commits into from
Apr 2, 2024
Merged

Support new API routes for edit profile social media #216

merged 5 commits into from
Apr 2, 2024

Conversation

alexzhang1618
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Apr 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 0:37am

SheepTester
SheepTester reviewed Apr 2, 2024
View reviewed changes
Copy link
Member

@SheepTester SheepTester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_20240401-171236

For some reason it's not refreshing the user cookie when you update the profile. Not sure if this was an issue before

Steps:

  1. Add social media
  2. Save
  3. Reload edit profile page

SheepTester
SheepTester approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@SheepTester SheepTester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it works

@alexzhang1618 alexzhang1618 merged commit 03e88bf into main Apr 2, 2024
6 checks passed
@alexzhang1618 alexzhang1618 deleted the fix-profile branch April 2, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SheepTester SheepTester SheepTester approved these changes

@farisashai farisashai Awaiting requested review from farisashai farisashai is a code owner

@raymosun raymosun Awaiting requested review from raymosun raymosun is a code owner

@trevorkw7 trevorkw7 Awaiting requested review from trevorkw7 trevorkw7 is a code owner

Assignees

@alexzhang1618 alexzhang1618

Labels
PR: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexzhang1618 @SheepTester