-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix: Fix users not being able to submit a second feedback #218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Can open multiple events in a new tab 2. Can't have a feedback <form> inside a modal
turns out you can't change status after responding
And add titles to new pages
backend suggestion
change currentColor borders to elevated-stroke
…s spacing, feedback form submit btn
…eedback components to its own folder
…ership-portal-ui-v2 into sean/event-feedback
since they don't work for non-admins
SheepTester
requested review from
farisashai,
raymosun,
trevorkw7 and
alexzhang1618
as code owners
April 2, 2024 05:06
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fixed by acmucsd/membership-portal#424 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info
Currently, users can only submit one feedback in their lifetimes, since the rest of the events will list that one feedback they submitted instead of allowing them to submit feedback for that event.
This is because currently, the event page uses query parameters to filter feedback by user and event ID. However, these query parameters are ignored if the user doesn't have the permission to see all feedback.
I think this is an issue with the backend's design, but whatever. Instead, this now fetches all feedback (for admins, this will fetch every feedback ever submitted) and then filters through that array. This matches the current behavior of checking for attendance: to check if a user has attended a specific event, it fetches the user's entire attendance history then looks up the event ID.
Reproduction steps:
Changes
Type of Change
expected)
linting/formatting)
workflows)
Testing
I have tested that my changes fully resolve the linked issue ...
Checklist
/src/lib/*
and commented hard to understand areasanywhere else.
Screenshots