Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for partially fulfilled events #252

Merged
merged 4 commits into from
May 10, 2024
Merged

Conversation

alexzhang1618
Copy link
Contributor

Info

Closes #251.

  • Fixing a bug where partially fulfilled events couldn't be rescheduled.
  • Updating Admin pickup event UI to reflect what items have/haven't been fulfilled
  • Changing views for partially fulfilled/placed order cards
    • if placed and some items have been fulfilled hide them (they were fulfilled in a previous order)
    • if partially fulfilled and some items have been fulfilled mark them as fulfilled...

Type of Change

  • Bug Fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Logistics Change (A change to a README, description, or dev workflow setup like
    linting/formatting)
  • Continuous Integration Change (Related to deployment steps or continuous integration
    workflows)
  • Other: (Fill In)

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally on Desktop.
  • on the live deployment preview on Desktop.
  • on the live deployment preview on Mobile.
  • I have added new Cypress tests that are passing.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have documented any new functions in /src/lib/* and commented hard to understand areas
    anywhere else.
  • My changes produce no new warnings.

Screenshots

Screenshot 2024-05-08 at 5 11 16 PM
Screenshot 2024-05-08 at 5 11 42 PM

Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 10:27pm
testing-membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 10:27pm

Copy link
Member

@SheepTester SheepTester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

We can refine the design for fulfilled items in the fulfill order PR #244

@SheepTester
Copy link
Member

chrome_screenshot_May 9, 2024 7_39_40 p m  PDT
Screenshot_20240509-193825
A lot of Bartholomew admin's partially fulfilled orders have some items fulfilled, others not. But they're all shown as not fulfilled here

One way to fix this is to also account for fulfillment in get item quantities, which is what's done in #244

@alexzhang1618
Copy link
Contributor Author

Screenshot 2024-05-10 at 3 26 15 PM Reworking the design in line with what Amy sent me:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants