-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial profile page design #30
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i know this is nowhere near done but left a few comments - good progress so far 👍
src/pages/u/[handle].tsx
Outdated
<h2>Rank Here</h2> | ||
</div> | ||
</div> | ||
<div className={styles.iconBox}>icon icon icon icon</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
message me if you need help getting data to test the social media links with. i know we haven't implemented a way to add a link to your profile yet
Whoops I don't know why I clicked approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few more comments
This reverts commit dc3c72c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a button that links to the edit profile page if the user is viewing their own profile?
This branch won't deploy, possibly because it's very old. The branch is dead 🪦, long live the branch #117. |
Info
Implements #29. (If there is no issue for this pull request yet, please create one or
delete this line if the pull request is for a very minor tweak).
Description
What changes did you make? List all distinct problems that this PR addresses. Explain any relevant
motivation or context.
Added layout for profile page based on preliminary designs.
Changes
Modifies profile page to begin implementing information display. Adds styles for
u/[handle]
page.Type of Change
expected)
linting/formatting)
workflows)
Testing
I have tested that my changes fully resolve the linked issue ...
Checklist
src/lib
functions and commented hard to understand areasanywhere else.
Screenshots
Please include a screenshot of your Cypress testing suite passing successfully.
If you made any visual changes to the website, please include relevant screenshots below.
Currently looks like this