Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial profile page design #30

Closed
wants to merge 13 commits into from
Closed

Conversation

raymosun
Copy link
Contributor

@raymosun raymosun commented May 8, 2023

Info

Implements #29. (If there is no issue for this pull request yet, please create one or
delete this line if the pull request is for a very minor tweak).

Description

What changes did you make? List all distinct problems that this PR addresses. Explain any relevant
motivation or context.

Added layout for profile page based on preliminary designs.

Changes

Modifies profile page to begin implementing information display. Adds styles for u/[handle] page.

Type of Change

  • Bug Fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Logistics Change (A change to a README, description, or dev workflow setup like
    linting/formatting)
  • Continuous Integration Change (Related to deployment steps or continuous integration
    workflows)
  • Other: (Fill In)

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally on Desktop.
  • locally on mobile - use https://ngrok.io to get a copy on a mobile device
  • on the live deployment preview on Desktop.
  • on the live deployment preview on Mobile.
  • I have run and passed all new and existing Cypress tests. Add screenshots below.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have documented my code's src/lib functions and commented hard to understand areas
    anywhere else.
  • My changes produce no new warnings.

Screenshots

Please include a screenshot of your Cypress testing suite passing successfully.

If you made any visual changes to the website, please include relevant screenshots below.

Currently looks like this
image

@vercel
Copy link

vercel bot commented May 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
membership-portal-ui-v2 ❌ Failed (Inspect) Jan 1, 2024 7:30am

farisashai
farisashai previously approved these changes May 8, 2023
Copy link
Member

@farisashai farisashai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i know this is nowhere near done but left a few comments - good progress so far 👍

src/pages/u/[handle].tsx Outdated Show resolved Hide resolved
src/pages/u/[handle].tsx Outdated Show resolved Hide resolved
src/styles/pages/u.module.scss Outdated Show resolved Hide resolved
src/pages/u/[handle].tsx Outdated Show resolved Hide resolved
<h2>Rank Here</h2>
</div>
</div>
<div className={styles.iconBox}>icon icon icon icon</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

message me if you need help getting data to test the social media links with. i know we haven't implemented a way to add a link to your profile yet

src/pages/u/[handle].tsx Outdated Show resolved Hide resolved
@farisashai
Copy link
Member

Whoops I don't know why I clicked approve

Copy link
Member

@farisashai farisashai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few more comments

src/styles/pages/u.module.scss.d.ts Outdated Show resolved Hide resolved
src/styles/pages/user-profile.module.scss Outdated Show resolved Hide resolved
src/styles/pages/user-profile.module.scss Show resolved Hide resolved
src/lib/utils.ts Outdated Show resolved Hide resolved
@farisashai farisashai removed this from the Create User Profile Page milestone May 10, 2023
@farisashai farisashai linked an issue May 12, 2023 that may be closed by this pull request
Copy link
Member

@farisashai farisashai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a button that links to the edit profile page if the user is viewing their own profile?

@raymosun
Copy link
Contributor Author

raymosun commented Jan 8, 2024

This branch won't deploy, possibly because it's very old. The branch is dead 🪦, long live the branch #117.

@raymosun raymosun closed this Jan 8, 2024
@raymosun raymosun deleted the raymond/user-profile-page branch January 8, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create User Profile Page
2 participants