-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
55 create store collections page #92
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've fixed the merge compatibility issues and fixed some of the bugs I saw
(tip that I learned: using git checkout origin/main [filepathshere]
is way more efficient than copying and pasting main's files by hand)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
everything is coming together 🦀🦀
Done! Thanks for fixing the merge problem Alex, and thanks for helping me find all the necessary files and imports Sean! |
Info
Closes 55: Create Store Collections Page.
Description
The collections page opens when the user clicks open the collections cards on the store page, and it displays all the items within the collection.
Note: after I wrote and committed this code, I realized I was one change behind the main branch, so I merged the changes to my branch. It broke the code though, so I reversed the merge commit on this branch - that means I'm probably missing some code and this PR will look horrible to review - I will probably need some help fixing that aah
Changes
Type of Change
expected)
linting/formatting)
workflows)
Testing
I have tested that my changes fully resolve the linked issue ...
Checklist
src/lib
functions and commented hard to understand areasanywhere else.
Screenshots
Please include a screenshot of your Cypress testing suite passing successfully.
If you made any visual changes to the website, please include relevant screenshots below.