Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COINBASEPRO-4] feature/ WebsocketClient #3

Closed
wants to merge 20 commits into from

Conversation

drewrice2
Copy link

@drewrice2 drewrice2 commented Jul 27, 2018

Issue link: #4

While this is just a first draft, I think it covers most of the functionality from the GDAX Python module's WebsocketClient (to which i was also a contributor).

This implementation purposefully does not deserialize Coinbase's returned JSON. It simply appends the JSON string to a logfile, delimited by newlines.

Please let me know what else you think this needs.

If anyone's interested, the "[COINBASEPRO-1]" tag is a reference to the repository and issue number.

@drewrice2 drewrice2 changed the title [COINBASEPRO-1] feature/ WebsocketClient [COINBASEPRO-4] feature/ WebsocketClient Jul 27, 2018
@drewrice2
Copy link
Author

@acontry I'll squash-and-merge, should you approve

@acontry
Copy link
Owner

acontry commented Aug 2, 2018

I appreciate all the work! I want to think carefully about the websocket interface, and also how we can have both threaded and asyncio versions available. I want to wrap up some changes to REST interface then tackle this next.

@drewrice2
Copy link
Author

@acontry totally understand. Happy to work together on that if you'd like. Standing by for further instruction.

@drewrice2 drewrice2 closed this Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants