Skip to content

Conversation

@grealish
Copy link
Member

@grealish grealish commented Mar 9, 2022

This is initial PR to test the parsec demo and iron out the issues,
please test the deployment in the 56K - Dev AWS account or your own AWS account

HOWTO:

  • git pull repo, and checkout building_parsec_workshop
  • cd into greengrass_parsec_workshop/
  • create secrets.env file with the following:

AWS_ACCESS_KEY_ID=
AWS_SECRET_ACCESS_KEY=
AWS_REGION=eu-central-1

  • run ./build_demo.sh (it should build and then run)
    Can take up to 11mins based on how long the AWS CRT and Device SDK builds for

@grealish grealish requested review from Vad1mo, elft3r and samspycher March 9, 2022 07:20
@grealish
Copy link
Member Author

@elft3r Thanks for testing, added your comments here

[Jochen[1 hour ago
hey @darragh, I have now managed to walk through the demo and successfully execute the build_demo.sh script. To do so, I had to fix some things and made some additional changes. Shall I directly push to the building_parsec_workshop branch or shall I create a PR into this branch, so that you can better see the changes I made?

@elft3r
Copy link

elft3r commented Mar 16, 2022

I pushed now the changes that were needed to allow a demo run with a fresh system. In addition, I updated the READMEs.

Before you begin you should be familiar with PARSEC and AWS IoT Greengrass. You should have at least deployed both and understand the use case of both technologies, we recommend the following to become familiar

* [AWS IoT Greengrass V2 Workshop](https://catalog.us-east-1.prod.workshops.aws/v2/workshops/5ecc2416-f956-4273-b729-d0d30556013f/en-US/)
* PARSEC Walkthrough with
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what walkthrough are you referencing here?

@@ -12,11 +12,13 @@ if test -e /etc/hostname; then
fi

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would fail if hostname contains dots. GG think name can't contains dots, a full hostname might

echo "... greengrass patched successfully built."
}

function copy_deps_from_greengrass_patched_to_local() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we still use this function? The local repository is not used for the demo build. I think it's left from some dev testing.

echo "Build greengrass patched ..."
pushd ./aws-greengrass-parsec-provider/parsec-greengrass-run-config/docker/
docker build . \
--build-arg BUILD_TS=${DIRTY_TS} \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we require/use this parameter? In my testing I've removed it and the dirty_build_on_new_commits function I haven't noticed any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants