-
Notifications
You must be signed in to change notification settings - Fork 1
WIP - Adding AWS Greengrass - Parsec Demo #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@elft3r Thanks for testing, added your comments here
|
|
I pushed now the changes that were needed to allow a demo run with a fresh system. In addition, I updated the READMEs. |
| Before you begin you should be familiar with PARSEC and AWS IoT Greengrass. You should have at least deployed both and understand the use case of both technologies, we recommend the following to become familiar | ||
|
|
||
| * [AWS IoT Greengrass V2 Workshop](https://catalog.us-east-1.prod.workshops.aws/v2/workshops/5ecc2416-f956-4273-b729-d0d30556013f/en-US/) | ||
| * PARSEC Walkthrough with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what walkthrough are you referencing here?
| @@ -12,11 +12,13 @@ if test -e /etc/hostname; then | |||
| fi | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would fail if hostname contains dots. GG think name can't contains dots, a full hostname might
| echo "... greengrass patched successfully built." | ||
| } | ||
|
|
||
| function copy_deps_from_greengrass_patched_to_local() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we still use this function? The local repository is not used for the demo build. I think it's left from some dev testing.
| echo "Build greengrass patched ..." | ||
| pushd ./aws-greengrass-parsec-provider/parsec-greengrass-run-config/docker/ | ||
| docker build . \ | ||
| --build-arg BUILD_TS=${DIRTY_TS} \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we require/use this parameter? In my testing I've removed it and the dirty_build_on_new_commits function I haven't noticed any issues.
This is initial PR to test the parsec demo and iron out the issues,
please test the deployment in the 56K - Dev AWS account or your own AWS account
HOWTO:
building_parsec_workshopgreengrass_parsec_workshop/Can take up to 11mins based on how long the AWS CRT and Device SDK builds for