dApp: AcreTVLProgress component mask fix#895
Draft
kpyszkowski wants to merge 2 commits intomainfrom
Draft
Conversation
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for acre-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
kkosiorowska
left a comment
kkosiorowska
left a comment
There was a problem hiding this comment.
I have tested solution on smaller screens and the TVL component doesn't always look good. See below:
Screen.Recording.2024-11-25.at.09.40.23.mov
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
AcreTVLProgresscomponent was not responsive looking bad on mobile. This PR fixes it.The only flaw are bottom rounded corners which are not very rounded on mobile. It's baked into the mask so it scales accordingly to the viewport - the smaller screen is, the smaller is the radius. It's unavoidable. Still looks better than before.
Before:
After:
