fix: include Across supported tokens in /swap/tokens endpoint #1927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melisaguevara
requested review from
NikolasHaimerl,
amateima,
ashwinrava,
dohaki,
mrice32,
nicholaspai and
pxrl
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ashwinrava
reviewed
Oct 30, 2025
api/swap/tokens/index.ts
Outdated
| ? constants.AddressZero | ||
| : route.fromTokenAddress; | ||
|
|
||
| const tokenKey = `${route.fromChain}-${route.fromTokenSymbol}-${tokenAddress.toLowerCase()}`; |
Member
There was a problem hiding this comment.
Is it okay to only look at route.fromTokenSymbol? Would we miss some tokens which are only defined as destination tokens like USDC.e, USDbC, etc?
Contributor
Author
There was a problem hiding this comment.
Good call! The only token that matched this condition right now was USDbC on Base, which was already included since it’s part of third party lists. Still, to make this more future-proof, I’ve added those here: 873d726
NikolasHaimerl
approved these changes
Nov 4, 2025
Contributor
NikolasHaimerl
left a comment
NikolasHaimerl
left a comment
There was a problem hiding this comment.
LGTM, thanks for implementing the price lookup :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes Across supported tokens in the response of /swap/tokens endpoint.
These are the new tokens that will be part of the response with the current enabled routes: