Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] Migration to 16.0 : field cmis_document #185

Open
wants to merge 60 commits into
base: 16.0
Choose a base branch
from
Open

[MIG] Migration to 16.0 : field cmis_document #185

wants to merge 60 commits into from

Conversation

benwillig
Copy link
Contributor

@benwillig benwillig commented Dec 21, 2023 •
edited
Loading

Based on:

Changed done:

  • cmis_document field + its widget
  • updated cmis_actions to allow dynamic actions
  • remove props inheritance of cmis_actions from cmis_table

To do:

  • "link to an existing document" for a cmis_document

image
image

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 30.92105% with 105 lines in your changes are missing coverage. Please review.

Project coverage is 69.77%. Comparing base (c6c1822) to head (84f1ca8).

Files Patch % Lines
cmis_field/fields/cmis_document.py 25.00% 81 Missing ⚠️
cmis_field/controllers/main.py 31.81% 15 Missing ⚠️
..._web/mixins/cmis_document_link_src_folder_mixin.py 52.63% 9 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             16.0     #185       +/-   ##
===========================================
- Coverage   86.71%   69.77%   -16.94%     
===========================================
  Files          33       48       +15     
  Lines        1061     1535      +474     
  Branches      124      212       +88     
===========================================
+ Hits          920     1071      +151     
- Misses        117      440      +323     
  Partials       24       24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benwillig benwillig force-pushed the mig-16.0_cmis_document-bwi branch 3 times, most recently from c6a4bd9 to 4ed1e37 Compare January 4, 2024 16:14
@marielejeune
Copy link
Contributor

Hi @benwillig
On Chrome we get the following error when trying to open a notebook page with a CmisDocument field inside.
On Firefox no error, it's working. It seems to be linked to this PR. Do you have any idea? (This is reproducible on the Accrefug Silog app, if you want).
image

@benwillig
Copy link
Contributor Author

@marielejeune It should be fixed now.

@benwillig benwillig changed the title [WIP][MIG] Migration to 16.0 : field cmis_document [MIG] Migration to 16.0 : field cmis_document May 28, 2024
pierre-halleux and others added 17 commits October 7, 2024 11:48
@pierre-halleux @benwillig
cmis document widget
8bc1144
@pierre-halleux @benwillig
cmis_field: add method to get cmis object to cmis_document field
bc94053
@pierre-halleux @benwillig
cmis_web: allow adding document when no value
ce948b1 
When there is no value on the cmis_document field, allows the user
to add a document to the GED and sets that document's objectId as
value to the cmis_document field.
@pierre-halleux @benwillig
document field: adapt fix to handle multiple backends
1442ee8 
see original PR: https://github.com/acsone/alfodoo/pull/154/files
@pierre-halleux @benwillig
cmis_field: remove file decoding from document creation
6f0f53a
@pierre-halleux @benwillig
cmis_field: properly decode file before adding new document
3b8484c
@benwillig
[MIG] field cmis_document: migration to 16.0
3e836e8
@pierre-halleux @benwillig
add a created column
dfcec84 
Add an "Created" column that allows ordering objects
in a folder by `cmis:creationDate`.
@benwillig
Update cmis_web.pot
6b9e289
@pierre-halleux @benwillig
cmis document widget
ab4c04d
@pierre-halleux @benwillig
refactoring of cmis_document widget
ce09f42
@pierre-halleux @benwillig
cmis_web: add preview to cmis_document
1d782c2
@pierre-halleux @benwillig
cmis_web: add versions to cmis_document
6b8ce17
@pierre-halleux @benwillig
cmis_web: Add Download to cmis_document
ecc7cc3
@pierre-halleux @benwillig
Hide dead buttons (context and alfresco) until fixed
88b45ef
@pierre-halleux @benwillig
cmis_web: make cmis_document widget usable in a treeview
ad37a22
@pierre-halleux @benwillig
cmis_document: remove file name from widget
10190b1
sbejaoui and others added 27 commits October 7, 2024 11:48
@sbejaoui @benwillig
- cmis document: add option to display file name
14e184c
@sbejaoui @benwillig
- cmis_document: stop event propagationat more action click
a572c7d
@sbejaoui @benwillig
- fix add document to cmis_folder
529edf0
@pierre-halleux @benwillig
cmis document: dropdown menu visibility
3a4cfd2
@pierre-halleux @benwillig
cmis_web: add import new document action
56dcba5
@pierre-halleux @benwillig
cmis_web:document: add version history
6ec238c
@pierre-halleux @benwillig
cmis_web: improve safety of the checkout process
b3c170b
@pierre-halleux @benwillig
cmis document: add show document details action
f348b0b
@pierre-halleux @benwillig
cmis_web: add possibility to link widget with an existing document
a7d2d33
@pierre-halleux @benwillig
pre-commit
27b0134
@benwillig
Prevent to trigger a reload if there was an error during the cmis upload
5807553
@benwillig
changed the way to display the document data to prevent the UI to be …
f7a1c99 
…blocked when there is an error message
@benwillig
updated translations
23d98cb
@benwillig
allow the dropdown actions to be visible when the widget is included …
6dff25e 
…in a x2many
@benwillig
hide the dropdown once the user entered and leaved the area or when c…
c0493e8 
…licking on an action
@jdoutreloux @benwillig
cmis_web: fix rendering of FieldCmisDocument In some cases the render…
9301cbf 
… gets triggered a second time and the empty value becomes false again. This causes the wrong template to be rendered and creates an error.
@jdoutreloux @benwillig
cmis_web: make cmis document available only in readonly mode If the u…
2bc6c13 
…ser is editing a record, when he adds a document with this widget his changes are discarded. To avoid this, we add the readonly class on the cmis document widget as it is done on cmis folder.
@benwillig
cmis_document: allow to search documents when linking to an existing …
96a8b6c 
…one. The source folders must be provided
@benwillig
allow to delete the link with the current document
d89a1a4
@benwillig
added translations
4ea84f2
@benwillig
[WIP] field cmis_document migration to 16.0
70d0569
@benwillig
[ADD] allow to link with an existing document
34820f0 
[REF] added some utils to prevent code duplication
@benwillig
[FIX] fix cased when there was no source folder to search on
b02d8ff
@benwillig
[FIX] stopPropagation of the click event to avoid opening the popup w…
e65921b 
…hen the widget is inside a tree view
@benwillig
[CHG] perform search when using enter key + prevent refresh when clic…
b0a0008 
…king on the dropdown button inside the cmis table + deleted console.log call
@benwillig
[ADD] allow to hide optional columns on cmis table + better handling …
d9b7c31 
…to avoid page refresh if optional columns is displayed
@benwillig
[FIX] dialogs title translations
1bac173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasBinsfeld ThomasBinsfeld ThomasBinsfeld approved these changes

Assignees
No one assigned
Labels
Needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@benwillig @codecov-commenter @marielejeune @ThomasBinsfeld @acsone-git-bot @pierre-halleux @sbejaoui @jdoutreloux