[FIX] cmis_report_write: add override to render again to save files in cmis_folder #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qgroulard could you take a look? you removed this override when migrating the module to v16, maybe I'm missing something. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 16.0 #187 +/- ##
==========================================
+ Coverage 86.71% 86.96% +0.24%
==========================================
Files 33 33
Lines 1061 1066 +5
Branches 124 125 +1
==========================================
+ Hits 920 927 +7
Misses 117 117
+ Partials 24 22 -2 ☔ View full report in Codecov by Sentry. |
I guess it was simply forgotten 🤔 |
qgroulard
approved these changes
Feb 26, 2024
ThomasBinsfeld
approved these changes
Feb 26, 2024
jdoutreloux
force-pushed
the
fix-cmis_report_write_render-jdo
branch
from
56dece7
to
1402317
Compare
…n cmis folder When rendering a report, the files weren't saved in the cmis folder because the override was missing.
ir.model.fields are not accessible by users anymore, we need to use sudo
FrancoMaxime
force-pushed
the
fix-cmis_report_write_render-jdo
branch
from
1402317
to
93e258d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendering a report, the files weren't saved in the cmis folder because the override was missing.