add restoredb command #57

lmignon · 2019-10-11T13:43:52Z

fixes #32
includes #58

codecov-io · 2019-10-11T14:28:11Z

Codecov Report

Merging #57 into master will decrease coverage by 1.22%.
The diff coverage is 76.47%.

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
- Coverage   93.84%   92.61%   -1.23%     
==========================================
  Files          13       14       +1     
  Lines         763      826      +63     
  Branches      126      135       +9     
==========================================
+ Hits          716      765      +49     
- Misses         32       43      +11     
- Partials       15       18       +3

Impacted Files	Coverage Δ
click_odoo_contrib/restoredb.py	`70.37% <70.37%> (ø)`
click_odoo_contrib/_dbutils.py	`100.00% <100.00%> (ø)`
click_odoo_contrib/backupdb.py	`100.00% <100.00%> (ø)`
click_odoo_contrib/copydb.py	`97.43% <100.00%> (+0.06%)`	⬆️
click_odoo_contrib/manifest.py	`100.00% <0.00%> (+2.89%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90b8b47...67d56f2. Read the comment docs.

Olivier-LAURENT · 2019-10-31T22:17:11Z

Tested by file (not by folder) with success. Thanks, 👍

rousseldenis

Functional review! LGTM

GSLabIt · 2020-02-25T09:12:11Z

@lmignon is this ready to merge?

lmignon · 2020-03-02T07:43:37Z

@GSLabIt IMO yes it is. I'll resolve the conflicts into the next days

lmignon · 2020-03-03T11:15:53Z

@sbidoul @GSLabIt rebased and ready to merge

sbidoul · 2020-03-03T11:37:53Z

@lmignon don't we need to finish #58 first?

lmignon · 2020-03-03T12:48:01Z

@lmignon don't we need to finish #58 first?

indeed

lmignon · 2020-05-03T11:53:25Z

@sbidoul #58 finished

GSLabIt · 2020-05-27T14:02:23Z

@sbidoul any news on this? ready to merge? thx

GSLabIt · 2020-07-03T08:11:22Z

hi all, any chance to get this merged? thx

lmignon · 2020-07-06T12:44:33Z

@GSLabIt thank you for the reminder. This PR will be merged into the next weeks... we're a bit overloaded at the moment which leaves us little time to finalize the various reviews in progress.

GSLabIt · 2020-07-06T13:14:02Z

@lmignon thx for the feedback, looking forward for the merge.

rousseldenis · 2020-08-07T11:29:06Z

@lmignon @sbidoul We need to ask user or to add an option to erase filestore directory. As if it exists, the command raises an error.

rousseldenis · 2020-08-24T14:06:27Z

@lmignon @sbidoul We need to ask user or to add an option to erase filestore directory. As if it exists, the command raises an error.

But maybe in a ROADMAP so we can move forward on this

voronind · 2020-08-26T14:08:54Z

Raises error in Odoo 10.0

Traceback (most recent call last):
  File "/home/voronin/.local/share/virtualenvs/sintez_addons-7QRHjYmJ/lib/python2.7/site-packages/click_odoo/env_options.py", line 218, in _invoke
    return self.org_invoke(ctx)
  File "/home/voronin/.local/share/virtualenvs/sintez_addons-7QRHjYmJ/lib/python2.7/site-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/voronin/.local/share/virtualenvs/sintez_addons-7QRHjYmJ/lib/python2.7/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/home/voronin/.local/share/virtualenvs/sintez_addons-7QRHjYmJ/src/click-odoo-contrib/click_odoo_contrib/restoredb.py", line 109, in main
    _restore_from_file(dbname, backup, copy)
  File "/home/voronin/.local/share/virtualenvs/sintez_addons-7QRHjYmJ/src/click-odoo-contrib/click_odoo_contrib/restoredb.py", line 54, in _restore_from_file
    odoo.service.db.restore_db(dbname, backup_file, copy)
  File "/home/voronin/.local/share/virtualenvs/sintez_addons-7QRHjYmJ/lib/python2.7/site-packages/odoo/service/db.py", line 262, in restore_db
    if odoo.tools.exec_pg_command(pg_cmd, *pg_args):
  File "/home/voronin/.local/share/virtualenvs/sintez_addons-7QRHjYmJ/lib/python2.7/site-packages/odoo/tools/misc.py", line 123, in exec_pg_command
    rc = subprocess.call(args2, env=env, stdout=dn, stderr=subprocess.STDOUT)
  File "/usr/lib/python2.7/subprocess.py", line 172, in call
    return Popen(*popenargs, **kwargs).wait()
  File "/usr/lib/python2.7/subprocess.py", line 394, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1047, in _execute_child
    raise child_exception
TypeError: coercing to Unicode: need string or buffer, file found```

lmignon · 2020-08-27T06:41:04Z

Raises error in Odoo 10.0

Thank you @voronind for the report. Unfortunately, it is very difficult to start investigating a potential problem with only a stack-trace 😏 Can you provide more information on how you use the script. On my side, I've been using it without any problem for months also on Odoo 10.

Regards

voronind · 2020-08-27T07:39:26Z

I try restore Odoo Postgres Dump (not Zip with files). And AFAIK `odoo.tools.exec_pg_command` get file object instead of string with file path. чт, 27 авг. 2020 г. в 10:41, Laurent Mignon (ACSONE) < [email protected]>:

…

Raises error in Odoo 10.0 Thank you @voronind <https://github.com/voronind> for the report. Unfortunately, it is very difficult to start investigating a potential problem with only a stack-trace 😏 Can you provide more information on how you use the script. On my side, I've been using it without any problem for months also on Odoo 10. Regards — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#57 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMBIUQ7IRN2VAS7XJPKOJ3SCX5Y3ANCNFSM4I7Z7TPQ> .

voronind · 2020-08-27T07:42:14Z

click_odoo_contrib/restoredb.py

+
+def _restore_from_file(dbname, backup, copy=True):
+    with db_management_enabled(), open(backup, "rb") as backup_file:
+        odoo.service.db.restore_db(dbname, backup_file, copy)


Odoo 10 wants file path here? Not file object.

lmignon · 2020-08-27T07:57:38Z

I try restore Odoo Postgres Dump (not Zip with files). And AFAIK odoo.tools.exec_pg_command get file object instead of string with file path.

@voronind there is probably a misunderstanding in the way of using the script. The input must be a path to an Odoo backup zip file or a path to a backup directory created by the click-odoo-backupdb command.

voronind · 2020-08-27T09:54:59Z

I try restore Odoo Postgres Dump (not Zip with files). And AFAIK odoo.tools.exec_pg_command get file object instead of string with file path.

@voronind there is probably a misunderstanding in the way of using the script. The input must be a path to an Odoo backup zip file or a path to a backup directory created by the click-odoo-backupdb command.

Then I request feature. Restore Odoo backup dump file.

lmignon · 2020-08-27T10:03:56Z

Then I request feature. Restore Odoo backup dump file.

@voronind You're welcome to contribute to this PR

elvise · 2020-09-02T19:07:56Z

Hi guys what's the status of this ?

sbidoul · 2020-09-05T10:53:31Z

Hi folks, sorry for the delay with this PR. I hope come back to it in the next month or so, unless @lmignon beats me to it :)

codecov-commenter · 2020-09-30T21:15:47Z

Codecov Report

Merging #57 into master will decrease coverage by 1.53%.
The diff coverage is 73.33%.

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
- Coverage   94.15%   92.62%   -1.54%     
==========================================
  Files          13       14       +1     
  Lines         770      827      +57     
  Branches      127      135       +8     
==========================================
+ Hits          725      766      +41     
- Misses         31       43      +12     
- Partials       14       18       +4

Impacted Files	Coverage Δ
click_odoo_contrib/restoredb.py	`70.37% <70.37%> (ø)`
click_odoo_contrib/backupdb.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 450e70f...18ddc0f. Read the comment docs.

sbidoul · 2020-09-30T21:37:10Z

Rebased. If green tomorrow I'll merge and release.

For consistency with backupdb.

sbidoul · 2020-10-01T06:53:38Z

@rousseldenis @voronind I'm going to release this as is, I think it is good enough. If you have identified issues or missing feature, can you please open separate issues to discuss them ?

GSLabIt · 2020-10-01T07:26:51Z

@sbidoul pip package will be released as well?

sbidoul · 2020-10-01T07:36:00Z

The release is on it's way to PyPI, as soon as travis catches up: https://travis-ci.com/github/acsone/click-odoo-contrib/builds/187542839

lmignon force-pushed the master-add-restordb-command branch 6 times, most recently from 68f41cf to b788821 Compare October 12, 2019 09:58

sbidoul added the enhancement New feature or request label Nov 1, 2019

rousseldenis approved these changes Dec 16, 2019

View reviewed changes

lmignon force-pushed the master-add-restordb-command branch 2 times, most recently from 82f8529 to 23900a2 Compare March 3, 2020 10:56

lmignon force-pushed the master-add-restordb-command branch 2 times, most recently from ce3cebf to 13b5ada Compare May 3, 2020 09:14

acsone-git-bot added the needs review label May 3, 2020

lmignon force-pushed the master-add-restordb-command branch from 13b5ada to 67d56f2 Compare May 12, 2020 14:57

voronind reviewed Aug 27, 2020

View reviewed changes

This was referenced Aug 27, 2020

Fix restore command #78

Closed

RestoreDB: Fix restoring from Postgres Dump file #79

Closed

add restoredb command

d75255f

sbidoul force-pushed the master-add-restordb-command branch from 67d56f2 to d75255f Compare September 30, 2020 21:15

sbidoul added 2 commits September 30, 2020 23:33

Tweak help and readme for backupdb/restoredb

ae217e3

Typo

fb4550b

sbidoul added 2 commits September 30, 2020 23:44

Use SOURCE for restoredb argument name

aa7556e

For consistency with backupdb.

restoredb: tweak warning message

18ddc0f

sbidoul merged commit 10ad6ae into master Oct 1, 2020

acsone-git-bot deleted the master-add-restordb-command branch October 1, 2020 06:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add restoredb command #57

add restoredb command #57

lmignon commented Oct 11, 2019 •

edited

Loading

codecov-io commented Oct 11, 2019 •

edited

Loading

Olivier-LAURENT commented Oct 31, 2019

rousseldenis left a comment

GSLabIt commented Feb 25, 2020

lmignon commented Mar 2, 2020

lmignon commented Mar 3, 2020

sbidoul commented Mar 3, 2020

lmignon commented Mar 3, 2020

lmignon commented May 3, 2020

GSLabIt commented May 27, 2020

GSLabIt commented Jul 3, 2020

lmignon commented Jul 6, 2020

GSLabIt commented Jul 6, 2020

rousseldenis commented Aug 7, 2020

rousseldenis commented Aug 24, 2020

voronind commented Aug 26, 2020

lmignon commented Aug 27, 2020

voronind commented Aug 27, 2020 via email

voronind Aug 27, 2020

lmignon commented Aug 27, 2020

voronind commented Aug 27, 2020

lmignon commented Aug 27, 2020

elvise commented Sep 2, 2020

sbidoul commented Sep 5, 2020

codecov-commenter commented Sep 30, 2020 •

edited

Loading

sbidoul commented Sep 30, 2020

sbidoul commented Oct 1, 2020

GSLabIt commented Oct 1, 2020

sbidoul commented Oct 1, 2020

add restoredb command #57

add restoredb command #57

Conversation

lmignon commented Oct 11, 2019 • edited Loading

codecov-io commented Oct 11, 2019 • edited Loading

Codecov Report

Olivier-LAURENT commented Oct 31, 2019

rousseldenis left a comment

Choose a reason for hiding this comment

GSLabIt commented Feb 25, 2020

lmignon commented Mar 2, 2020

lmignon commented Mar 3, 2020

sbidoul commented Mar 3, 2020

lmignon commented Mar 3, 2020

lmignon commented May 3, 2020

GSLabIt commented May 27, 2020

GSLabIt commented Jul 3, 2020

lmignon commented Jul 6, 2020

GSLabIt commented Jul 6, 2020

rousseldenis commented Aug 7, 2020

rousseldenis commented Aug 24, 2020

voronind commented Aug 26, 2020

lmignon commented Aug 27, 2020

voronind commented Aug 27, 2020 via email

voronind Aug 27, 2020

Choose a reason for hiding this comment

lmignon commented Aug 27, 2020

voronind commented Aug 27, 2020

lmignon commented Aug 27, 2020

elvise commented Sep 2, 2020

sbidoul commented Sep 5, 2020

codecov-commenter commented Sep 30, 2020 • edited Loading

Codecov Report

sbidoul commented Sep 30, 2020

sbidoul commented Oct 1, 2020

GSLabIt commented Oct 1, 2020

sbidoul commented Oct 1, 2020

lmignon commented Oct 11, 2019 •

edited

Loading

codecov-io commented Oct 11, 2019 •

edited

Loading

codecov-commenter commented Sep 30, 2020 •

edited

Loading