Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17.0: don't preinstall setuptools and wheel #29

Closed
wants to merge 1 commit into from

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Feb 1, 2024

This forces pip to use build isolation by default for legacy setup.py projects. Since OCA addons use pyproject.toml there is no reason to have setuptools pre-installed.

This forces pip to use build isolation by default for legacy setup.py projects.
Since OCA addons use pyproject.toml there is no reason to have setuptools pre-installed.
@sbidoul sbidoul marked this pull request as draft June 13, 2024 16:25
@sbidoul
Copy link
Member Author

sbidoul commented Jun 13, 2024

We'll do this for 18

@sbidoul
Copy link
Member Author

sbidoul commented Sep 13, 2024

And since in 18, we'll use python 3.12 which does this by default, we can close this PR.

@sbidoul sbidoul closed this Sep 13, 2024
@sbidoul sbidoul deleted the 17.0-no-setuptools-wheel branch September 13, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant