Open
Conversation
Contributor
|
Hello @MClimate and @yordan-zaychev, The fixes seems to be great following your updates on the "points" section (even if no need to modify the output of decodeUplink). However, I see in all the drivers, in the directory "/json-schemas" the json file is copied as it is from the template and was not adapted with the data outputted in your driver. Can you please update it? Otherwise you can remove the directory as it is not mandatory. |
ErwannWICART
approved these changes
Sep 19, 2022
Contributor
ErwannWICART
left a comment
ErwannWICART
left a comment
There was a problem hiding this comment.
All seems right.
You still got an "unsupported" -> extThermistorTemperature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.