Skip to content

Commit

Permalink
Merge pull request #404 from summerwind/fix-reg-update-runner-status-err
Browse files Browse the repository at this point in the history
Fix `Failed to update runner status for Registration` errors
  • Loading branch information
mumoshu authored Mar 18, 2021
2 parents 2929a73 + 23a45ea commit c5fdfd6
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 17 deletions.
15 changes: 9 additions & 6 deletions api/v1alpha1/runner_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -121,13 +121,16 @@ func (rs *RunnerSpec) ValidateRepository() error {

// RunnerStatus defines the observed state of Runner
type RunnerStatus struct {
// +optional
Registration RunnerStatusRegistration `json:"registration"`
Phase string `json:"phase"`
Reason string `json:"reason"`
Message string `json:"message"`

//+optional
LastRegistrationCheckTime *metav1.Time `json:"lastRegistrationCheckTime"`
// +optional
Phase string `json:"phase,omitempty"`
// +optional
Reason string `json:"reason,omitempty"`
// +optional
Message string `json:"message,omitempty"`
// +optional
LastRegistrationCheckTime *metav1.Time `json:"lastRegistrationCheckTime,omitempty"`
}

// RunnerStatusRegistration contains runner registration status
Expand Down
2 changes: 1 addition & 1 deletion charts/actions-runner-controller/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.10.2
version: 0.10.3

home: https://github.com/summerwind/actions-runner-controller

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1572,11 +1572,6 @@ spec:
- expiresAt
- token
type: object
required:
- message
- phase
- reason
- registration
type: object
type: object
version: v1alpha1
Expand Down
5 changes: 0 additions & 5 deletions config/crd/bases/actions.summerwind.dev_runners.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1572,11 +1572,6 @@ spec:
- expiresAt
- token
type: object
required:
- message
- phase
- reason
- registration
type: object
type: object
version: v1alpha1
Expand Down

0 comments on commit c5fdfd6

Please sign in to comment.