Skip to content

Allow extra args for docker daemon when in dind mode #4257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow extra args for docker daemon when in dind mode #4257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions charts/gha-runner-scale-set/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,13 @@ args:
- dockerd
- --host=unix:///var/run/docker.sock
- --group=$(DOCKER_GROUP_GID)
{{- /* Append extra args only if containerMode.dind.extraDockerDaemonArgs exists and is a list */ -}}
{{- if and (kindIs "map" .Values.containerMode) (kindIs "map" (get .Values.containerMode "dind")) -}}
{{- $extra := (get (get .Values.containerMode "dind") "extraDockerDaemonArgs") | default (list) -}}
{{- range $extra }}
- {{ . | quote }}
{{- end }}
{{- end }}
env:
- name: DOCKER_GROUP_GID
value: "123"
Expand Down
6 changes: 6 additions & 0 deletions charts/gha-runner-scale-set/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,12 @@ githubConfigSecret:
## empty, and configuration should be applied to the template.
# containerMode:
# type: "dind" ## type can be set to dind or kubernetes
# dind:
# ## extraDockerDaemonArgs is a list of extra arguments to pass to the docker daemon
# extraDockerDaemonArgs:
# - --registry-mirror=https://my-mirror.com
# - --https-proxy=http://my-proxy.com:1234
# - --mtu=1400
# ## the following is required when containerMode.type=kubernetes
# kubernetesModeWorkVolumeClaim:
# accessModes: ["ReadWriteOnce"]
Expand Down