Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ubuntu] Add pass package #2304

Merged
merged 1 commit into from
Dec 21, 2020
Merged

[Ubuntu] Add pass package #2304

merged 1 commit into from
Dec 21, 2020

Conversation

crazy-max
Copy link
Contributor

@crazy-max crazy-max commented Dec 18, 2020 •
edited
Loading

Description

Adds pass package

Related issue:

Fixes #2302

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

cc. @maxim-lobanov

@crazy-max
Copy link
Contributor Author

@maxim-lobanov Can you fire up an Azure pipeline just to make sure the regex is ok 😅

$ pass version
============================================
= pass: the standard unix password manager =
=                                          =
=                  v1.7.3                  =
=                                          =
=             Jason A. Donenfeld           =
=               [email protected]            =
=                                          =
=      http://www.passwordstore.org/       =
============================================

@maxim-lobanov
Copy link
Contributor

In general, looks good. I have left minor comment.

@crazy-max crazy-max mentioned this pull request Dec 18, 2020
Closed
4 tasks
@maxim-lobanov
Copy link
Contributor

/azp run ubuntu1604, ubuntu1804, ubuntu2004

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@crazy-max
Copy link
Contributor Author

crazy-max commented Dec 18, 2020 •
edited
Loading

@maxim-lobanov Argh looks like the regex is wrong. Should be ok now.

@maxim-lobanov
Copy link
Contributor

/azp run ubuntu1604, ubuntu1804, ubuntu2004

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@crazy-max
Copy link
Contributor Author

@maxim-lobanov

@maxim-lobanov
Copy link
Contributor

@maxim-lobanov

Great,
@actions/virtual-environments-akvelon could you please review and approve it too?

@Darleev Darleev self-requested a review December 20, 2020 15:55
@maxim-lobanov maxim-lobanov merged commit 7e4e97b into actions:main Dec 21, 2020
@crazy-max crazy-max deleted the add-pass branch December 21, 2020 19:03
@crazy-max crazy-max mentioned this pull request Dec 22, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darleev Darleev Darleev approved these changes

@al-cheb al-cheb al-cheb approved these changes

@MaksimZhukov MaksimZhukov MaksimZhukov approved these changes

@maxim-lobanov maxim-lobanov maxim-lobanov approved these changes

@AlenaSviridenko AlenaSviridenko AlenaSviridenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add pass credential helper
6 participants
@crazy-max @maxim-lobanov @AlenaSviridenko @MaksimZhukov @al-cheb @Darleev