Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIGTERM kills the job instead of waiting for job completion #3308

Open
jaswanthikolla opened this issue May 29, 2024 · 1 comment
Open

SIGTERM kills the job instead of waiting for job completion #3308

jaswanthikolla opened this issue May 29, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jaswanthikolla
Copy link

jaswanthikolla commented May 29, 2024

May be this can be a feature request but I don't see any discussions ( of any kind) at here, so not sure where to log it. And also, It's existing functionality too.

Describe the bug
In summerwind images, If we receive a SIGTERM the runners waits default 15 mins before killing a running job. With Scaled Sets ( ARSS), helmcharts use ghcr.io/actions/actions-runner images with run.sh entrypoint which lacks the graceful termination functionality. This functionality is expected as consistent between ARC and scaled sets.

To Reproduce
Steps to reproduce the behavior:

  1. Launch the Runner with a label.
  2. Run a workflow with the assigned label. Make sure to have a step of bash sleep statement to simulate long running job.
  3. Send SIGTERM signal. On kubernetes send a pod termination signal.
  4. Check if the workflow succeeded or not.

Expected behavior
These 2 different behaviors are expected based on running is running the job or not.

  • Run the runner without a job assigned, SIGTERM should be propagated and runner should exit.
  • Run the runner with a job assigned, SIGTERM should not be propagated and runner shouldn't exit unless job is finished with a reasonable grace period.

Runner Version and Platform

2.316.1

OS of the machine running the runner? Linux - Ubuntu 22

What's not working?

SIGTERM handling

@jaswanthikolla jaswanthikolla added the bug Something isn't working label May 29, 2024
@jaswanthikolla
Copy link
Author

I am ready to raise a PR for this if #3330 can be solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant