Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue:3308] SIGTERM Graceful shutdown functionality #3340

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Issue:3308] SIGTERM Graceful shutdown functionality #3340

wants to merge 1 commit into from
+40 −4

Conversation

jaswanthikolla
Copy link

@jaswanthikolla jaswanthikolla commented Jun 14, 2024 •
edited
Loading

This is to make runner compatible with Kubernetes' Karpenter, and in general k8s pod movement . This fixes the #3308 by handling graceful shutdown of the runner. It does following.

  1. If the runner is just listening for jobs and Idle, It will just exit.
  2. If the runner is running a job, It will wait RUNNER_GRACEFUL_STOP_TIMEOUT seconds before terminating or job completion whichever happens first.

@jaswanthikolla jaswanthikolla requested a review from a team as a code owner June 14, 2024 02:44
@jaswanthikolla jaswanthikolla mentioned this pull request Jun 14, 2024
Open
4 tasks
@jaswanthikolla
Copy link
Author

Any ETA on when can we expect a review on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaswebb nicolaswebb nicolaswebb approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jaswanthikolla @nicolaswebb