Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Scaled Sets, config.sh remove should just read from JitConfig( .runner/.credentials) or pass the runner token #3330

Open
jaswanthikolla opened this issue Jun 11, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jaswanthikolla
Copy link

jaswanthikolla commented Jun 11, 2024

Describe the bug
In ARSS/scaled sets, ACTIONS_RUNNER_INPUT_JITCONFIG env variable is set and RUNNER_TOKEN env variable is not set. JitConfig is used to register the runner, but the same flow doesn't make user of .runner and .credentials files ( or just ACTIONS_RUNNER_INPUT_JITCONFIG). So, Either of the following needs to be done to fix this.

  • Support remove runner with ACTIONS_RUNNER_INPUT_JITCONFIG
  • Scaled Set controller needs to Pass RUNNER_TOKEN along with jit config.

To Reproduce
Steps to reproduce the behavior:

  1. Launch a ARSS runner, it creates a runner with just-in-time registration, it launches ./run.sh with JITCONFIG Env variable
  2. run config.sh remove script, and it says Enter runner remove token

Expected behavior
Either Use JitConfig to do the remove runner or pass Runner token as env variable.

Runner Version and Platform

Version of your runner?
v2.317.0

OS of the machine running the runner? OSX/Windows/Linux/...
Ubuntu 22

What's not working?

RUNNER 2024-06-11 21:01:54Z INFO ConfigurationStore] IsServiceConfigured()
[RUNNER 2024-06-11 21:01:54Z INFO ConfigurationStore] IsServiceConfigured: False
[RUNNER 2024-06-11 21:01:54Z INFO ConfigurationStore] IsConfigured()
[RUNNER 2024-06-11 21:01:54Z INFO ConfigurationStore] IsConfigured: True
[RUNNER 2024-06-11 21:01:54Z INFO ConfigurationStore] HasCredentials()
[RUNNER 2024-06-11 21:01:54Z INFO ConfigurationStore] stored True
[RUNNER 2024-06-11 21:01:54Z INFO ConfigurationStore] Read setting file: 396 chars
[RUNNER 2024-06-11 21:01:54Z INFO CommandSettings] Arg 'token': ''
[RUNNER 2024-06-11 21:01:54Z INFO CommandSettings] Flag 'unattended': 'False'
[RUNNER 2024-06-11 21:01:54Z INFO PromptManager] ReadValue
[RUNNER 2024-06-11 21:01:54Z INFO Terminal] WRITE: Enter runner remove token: 
Enter runner remove token: [RUNNER 2024-06-11 21:01:54Z INFO Terminal] READ SECRET

Job Log Output

NA

Runner and Worker's Diagnostic Logs

already added in what's not working.

@jaswanthikolla jaswanthikolla added the bug Something isn't working label Jun 11, 2024
@jaswanthikolla jaswanthikolla changed the title For Scaled Sets, config.sh remove should just read from JitConfig or .runner/.credentials For Scaled Sets, config.sh remove should just read from JitConfig( .runner/.credentials) or pass the runner token Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant