. #3324
. #3324
Conversation
| @@ -62,7 +62,9 @@ public Task<AgentJobRequestMessage> GetJobMessageAsync(string id, CancellationTo | |||
| CheckConnection(); | |||
| return RetryRequest<AgentJobRequestMessage>( | |||
| async () => await _runServiceHttpClient.GetJobMessageAsync(requestUri, id, VarUtil.OS, cancellationToken), cancellationToken, | |||
| shouldRetry: ex => ex is not TaskOrchestrationJobAlreadyAcquiredException); | |||
| shouldRetry: ex => ex is not TaskOrchestrationJobNotFoundException && | |||
There was a problem hiding this comment.
keep, but maybe also keep a delay?
There was a problem hiding this comment.
don't make this change until we also figure out how to keep a delay
| @@ -1539,6 +1539,26 @@ private TaskOrchestrationJobAlreadyAcquiredException(SerializationInfo info, Str | |||
| } | |||
| } | |||
|
|
|||
| [Serializable] | |||
| @@ -0,0 +1,17 @@ | |||
| using System.Runtime.Serialization; | |||
| return true; | ||
| } | ||
| } | ||
| catch (Exception) |
There was a problem hiding this comment.
bubble this, so we can work it into the caller exception message
There was a problem hiding this comment.
maybe log the first N characters
| @@ -106,10 +106,11 @@ public void Dispose() | |||
| Uri requestUri, | |||
| HttpContent content = null, | |||
| IEnumerable<KeyValuePair<String, String>> queryParameters = null, | |||
| Boolean readErrorContent = false, | |||
There was a problem hiding this comment.
keep changes to this file
| public string Error { get; protected set; } | ||
|
|
||
| /// <summary> | ||
| /// The raw of the HTTP response, for unsuccessful HTTP status codes |
There was a problem hiding this comment.
"The raw string content"
| @@ -5,29 +5,41 @@ namespace Sdk.WebApi.WebApi | |||
| public class RawHttpClientResult | |||
| { | |||
| public bool IsSuccess { get; protected set; } | |||
|
|
|||
There was a problem hiding this comment.
keep changes to this file
| var errorContent = default(string); | ||
| if (readErrorContent) | ||
| { | ||
| errorContent = await response.Content.ReadAsStringAsync(cancellationToken).ConfigureAwait(false); |
There was a problem hiding this comment.
can this throw? if so, then can set the error content to the exception when trying to read
There was a problem hiding this comment.
if it throws because we hit a network error, then we want to let that bubble
No description provided.