Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add arch to cache key #896

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: add arch to cache key #896

wants to merge 2 commits into from

Conversation

Zxilly
Copy link

@Zxilly Zxilly commented Jun 18, 2024

Description:

GitHub has added the arm64 runner, so arch should be used as part of the cache key. Otherwise, if there are macos-13 macos-14 running at the same time, the late executor will get the wrong cache.

This problem is particularly acute for pipenv and poetry, for which action also caches the contents of venv. This prevents any libraries containing native binary dependencies from working properly.

For real-world error, see https://github.com/Zxilly/go-size-analyzer/actions/runs/9564444574/job/26365211564

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@Zxilly Zxilly requested a review from a team as a code owner June 18, 2024 12:31
@Zxilly
Copy link
Author

Zxilly commented Jun 19, 2024

@actions/setup-actions-team Can anyone review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant