Update PHP workflow to use shivammathur/setup-php #557
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add to this description at the bottom 👇
In the workflow and properties files:
The workflow filename of CI workflows should be the name of the language or platform, in lower case. Special characters should be removed or replaced with words as appropriate (for example, "dotnet" instead of ".NET").
The workflow filename of publishing workflows should be the name of the language or platform, in lower case, followed by "-publish".
Includes a matching
ci/properties/*.properties.jsonfile.Use sentence case for the names of workflows and steps, for example "Run tests".
The name of CI workflows should only be the name of the language or platform: for example "Go" (not "Go CI" or "Go Build")
Include comments in the workflow for any parts that are not obvious or could use clarification.
CI workflows should run on
pushtobranches: [ master ]andpull_requesttobranches: [ master ].Some general notes:
Continution of work done in #222 to follow new guidelines from #451
This updates the php workflow to use shivammathur/setup-php action to configure PHP for a variety of versions. This is some amount of the de-facto action to do this and is used by a variety of the big PHP projects (e.g. symfony) and I would say is a good candidate for usage in the official starter file This also promotes the starter file to a similar level as the other languages (e.g. python, nodejs).