Skip to content

Conversation

@MasterOdin
Copy link
Contributor

@MasterOdin MasterOdin commented Jun 23, 2020

Please add to this description at the bottom 👇

  • A good description of the workflow at the bottom of this page.
  • Some links to the language or tool will be nice (unless its really obvious)

In the workflow and properties files:

  • The workflow filename of CI workflows should be the name of the language or platform, in lower case. Special characters should be removed or replaced with words as appropriate (for example, "dotnet" instead of ".NET").

    The workflow filename of publishing workflows should be the name of the language or platform, in lower case, followed by "-publish".

  • Includes a matching ci/properties/*.properties.json file.

  • Use sentence case for the names of workflows and steps, for example "Run tests".

  • The name of CI workflows should only be the name of the language or platform: for example "Go" (not "Go CI" or "Go Build")

  • Include comments in the workflow for any parts that are not obvious or could use clarification.

  • CI workflows should run on push to branches: [ master ] and pull_request to branches: [ master ].

Some general notes:

  • This workflow must only use actions that are produced by the language or ecosystem that the workflow supports. These actions must be published to the GitHub Marketplace. Workflows using these actions must reference the action using the full 40 character hash of the action's commit instead of a tag. Additionally, workflows must include the following comment at the top of the workflow file:
    # This workflow uses actions that are not certified by GitHub.
    # They are provided by a third-party and are governed by
    # separate terms of service, privacy policy, and support
    # documentation.
    
  • This workflow must not send data to any 3rd party service except for the purposes of installing dependencies.
  • This workflow must not use a paid service or product.

Continution of work done in #222 to follow new guidelines from #451

This updates the php workflow to use shivammathur/setup-php action to configure PHP for a variety of versions. This is some amount of the de-facto action to do this and is used by a variety of the big PHP projects (e.g. symfony) and I would say is a good candidate for usage in the official starter file This also promotes the starter file to a similar level as the other languages (e.g. python, nodejs).

Copy link
Contributor

@shivammathur shivammathur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@github-actions
Copy link

This pull request has become stale and will be closed automatically within a period of time. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants