Versapay: Store Unstore #5315
Versapay: Store Unstore #5315
Conversation
This include the Store, Unstore methods, and transactions related with third_party_token Unit Tests ---------------- Finished in 0.070294 seconds. 27 tests, 159 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote Tests ---------------- Finished in 72.628972 seconds. 25 tests, 125 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Rubocop ---------------- 804 files inspected, no offenses detected
| @@ -141,6 +155,9 @@ def add_payment_method(post, payment_method, options) | |||
| cvv: payment_method.verification_value | |||
| } | |||
| add_address(post[:credit_card], options, 'billing', 'payment_method') | |||
| elsif payment_method.is_a?(String) | |||
| _, _, fund_token = payment_method.split('|') | |||
There was a problem hiding this comment.
💬 Comment/Style:
You can achieve basically the same result, by:
post[:fund_token] = payment_method.split('|').last| end | ||
|
|
||
| def unstore(authorization, options = {}) | ||
| _, wallet_token, fund_token = authorization.split('|') |
There was a problem hiding this comment.
💬 Comment / Style:
Same here
There was a problem hiding this comment.
Here I'm getting two values, not only the last one.
| def success_from(response) | ||
| response['success'] || false | ||
| def success_from(response, action) | ||
| case action |
There was a problem hiding this comment.
💬 Comment:
Is going o work anyway but is not consistent, see action can be 'purchase,capture,void' but you are mixing those actions with the endpoint 'wallets'
There was a problem hiding this comment.
cause the actions are the same as the endpoint, I'm not mapping it, they are just the same name.
|
|
||
| first_transaction = response['transactions']&.first | ||
| gateway_response_errors = gateway_errors_message(response) | ||
|
|
||
| response_message = { | ||
| errors: response['errors']&.join(', ').presence, | ||
| errors: response.dig('errors')&.join(', ').presence, |
There was a problem hiding this comment.
💬 Comment:
Whats the point of dig vs [ ] ?
There was a problem hiding this comment.
It was because of a different kind of error, but it was solved differently, it can be removed.
This include the Store, Unstore methods,
and transactions related with third_party_token
Unit Tests
Finished in 0.070294 seconds.
27 tests, 159 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Remote Tests
Finished in 72.628972 seconds.
25 tests, 125 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Rubocop
804 files inspected, no offenses detected