Adapt workspace crates to MessageBody::poll with Pin#1358
Merged
JohnTitor merged 3 commits intoactix:msg-bodyfrom Feb 19, 2020
Merged
Adapt workspace crates to MessageBody::poll with Pin#1358JohnTitor merged 3 commits intoactix:msg-bodyfrom
JohnTitor merged 3 commits intoactix:msg-bodyfrom
Conversation
dunnock
changed the title
robjtede
approved these changes
Feb 19, 2020
JohnTitor
approved these changes
Feb 19, 2020
Member
|
Nice work! |
Member
|
@dunnock Hey, we're close to new alpha-release for actix-http, are there remaining things you come up with? |
Contributor
Author
|
@JohnTitor I have reviewed changes once again and was only able to find one more discrepancy, created separate PR #1363 just in case those crates are still part of this project. Otherwise it all seems ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #1332 there are incompatibility issues in actix-web logger left as well as some tests need to be reenabled.
This PR is resolving incompatibility issues so that whole workspace would compile and run tests with local actix-http version. PR is still placed against msg-body branch.