Verbose performance metrics#578
Closed
SylvainJoube wants to merge 5 commits intoacts-project:mainfrom
Closed
Conversation
The greedy ambiguity resolution algorithm now returns a vector of selected tracks. This will be used for performance metrics.
8022b31 to
05dd1cf
Compare
Member
|
🤔 Over the next days I intend to put together a proposal for how I believe all of this performance measurement code should be organized. As I'm really not super happy with how it is set up at the moment. At that point, in a couple of days, let's discuss here how your development would fit into that "new landscape". 😉 |
Contributor
Author
|
Thanks for your feedback Attila. Okay, I’ll wait! I’m very curious about your proposal, seeing your code is always a nice way for me to discover how things should be organized and implemented! 🦊 See you here in a couple of days then :) I’ll be watching the open PRs too. |
Member
|
Closing this as superseded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added some performance metrics for the following algorithms:
finding,fittingandambiguity resolution. I think it's an easy way to have a simple evaluation of the algorithms performance, without having to open ROOT. The code compares the reconstructed track with the truth particle data and prints basic metrics (valid/duplicates/false tracks).My code still needs a bit of refactoring (I will clean it by the end of the day). I will also write a documentation, if you agree to merge this PR, and it you think this PR was a good idea. Here is an example of output I had:
I used the following command, with the added
--print-performanceflag: