Align amount conversion utilities between api and loot-core #5747
+12
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates api amount conversion utilities to align with loot-core, improving consistency and maintainability across the project. Uses decimal places as parameters in conversion functions.
actual-github-bot
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged No assets were unchanged |
StephenBrown2
changed the title
joel-jeremy
reviewed
Sep 19, 2025
| @@ -1,7 +1,9 @@ | |||
| export function amountToInteger(n) { | |||
| return Math.round(n * 100); | |||
| export function amountToInteger(amount, decimalPlaces = 2) { | |||
There was a problem hiding this comment.
Suggested change
| export function amountToInteger(amount, decimalPlaces = 2) { | |
| export function amountToInteger(amount: Amount, decimalPlaces = 2) { |
|
|
||
| export function integerToAmount(n) { | ||
| return parseFloat((n / 100).toFixed(2)); | ||
| export function integerToAmount(integerAmount, decimalPlaces = 2) { |
There was a problem hiding this comment.
Suggested change
| export function integerToAmount(integerAmount, decimalPlaces = 2) { | |
| export function integerToAmount(integerAmount: IntegerAmount, decimalPlaces = 2) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates api amount conversion utilities to align with loot-core, improving consistency and maintainability across the project.
Uses decimal places as parameters in conversion functions, just like the typescript equivalents.