Fix a small bug in the pattern creation #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO<joka921> Add a unit test that would have caught this bug.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1396 +/- ##
==========================================
+ Coverage 89.06% 89.15% +0.09%
==========================================
Files 328 332 +4
Lines 29294 29499 +205
Branches 3262 3291 +29
==========================================
+ Hits 26090 26301 +211
+ Misses 2054 2051 -3
+ Partials 1150 1147 -3 ☔ View full report in Codecov by Sentry. |
hannahbast
requested changes
Jul 15, 2024
hannahbast
approved these changes
Jul 15, 2024
|
hannahbast
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in the pattern creation when the first or last triple of a group of triples with the same subject was an "ignored" triple (where the predicate should not contribute towards the pattern). This is now fixed and tested and the code also became simpler.