Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up index build (compare without local vocab + hide handling of small relations in thread) #1416

Merged
merged 28 commits into from
Jul 31, 2024
Merged

Speed up index build (compare without local vocab + hide handling of small relations in thread) #1416

merged 28 commits into from
Jul 31, 2024

Conversation

joka921
Copy link
Member

@joka921 joka921 commented Jul 25, 2024 •
edited by hannahbast
Loading

  1. Compare without local vocab during index build
  2. Process blocks with small relations in a separate thread (especially relevant for the SPO&SOP permutation pair, where most "relations" are small)

@codecov Codecov
Copy link

codecov bot commented Jul 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.18310% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.54%. Comparing base (16f3f70) to head (9aff185).

Files Patch % Lines
src/index/StxxlSortFunctors.h 81.81% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1416      +/-   ##
==========================================
+ Coverage   89.52%   89.54%   +0.01%     
==========================================
  Files         342      342              
  Lines       29832    29869      +37     
  Branches     3311     3314       +3     
==========================================
+ Hits        26708    26747      +39     
+ Misses       1975     1971       -4     
- Partials     1149     1151       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hannahbast hannahbast changed the title Faster indexb building, part 1 of N Faster index building, part 1 of N Jul 29, 2024
hannahbast
hannahbast requested changes Jul 29, 2024
View reviewed changes
Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1-1 with Johannes, looks great, some minor changes

@hannahbast hannahbast changed the title Faster index building, part 1 of N Faster handling of small relations in index build Jul 29, 2024
@hannahbast hannahbast changed the title Faster handling of small relations in index build Speed up index build (compare without local vocab + hide handling of small relations in thread) Jul 29, 2024
hannahbast
hannahbast approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 31, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@joka921 joka921 merged commit 2c5d3ce into ad-freiburg:master Jul 31, 2024
20 checks passed
@joka921 joka921 deleted the faster-small-permutation-things branch July 31, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahbast hannahbast hannahbast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joka921 @hannahbast