Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better descriptor for implicit GROUP BY #1418

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

joka921
Copy link
Member

@joka921 joka921 commented Jul 26, 2024

An implicit GROUP BY that is performed because the SELECT clause contains aggregates, but no explicitly GROUP BY was stated, now has the descriptor GroupBy (implicit) which is less confusing than the previous descriptor GroupBy on.

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.63%. Comparing base (196a911) to head (8cfd9d5).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1418      +/-   ##
==========================================
+ Coverage   89.25%   89.63%   +0.37%     
==========================================
  Files         336      343       +7     
  Lines       29754    29951     +197     
  Branches     3315     3315              
==========================================
+ Hits        26558    26847     +289     
+ Misses       2032     1957      -75     
+ Partials     1164     1147      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree!

@hannahbast hannahbast changed the title Improve the descriptor for an Implicit GROUP BY Improve the descriptor for an implicit GROUP BY Aug 1, 2024
@hannahbast hannahbast changed the title Improve the descriptor for an implicit GROUP BY Better descriptor for an implicit GROUP BY Aug 1, 2024
@hannahbast hannahbast changed the title Better descriptor for an implicit GROUP BY Better descriptor for implicit GROUP BY Aug 1, 2024
Copy link

sonarcloud bot commented Aug 2, 2024

@joka921 joka921 merged commit 3fad814 into ad-freiburg:master Aug 2, 2024
20 checks passed
@joka921 joka921 deleted the group-by-descriptor-all-columns branch August 2, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants