Fix query planning for join with SERVICE clause

[joka921]

There is a bug in the optimization introduced by #1341, which checks whether the sibling operand of a join with a SERVICE operations has a small result (and if yes, passes that result to the SERVICE clause as VALUES in order to reduce the result size of the SERVICE call). Instead of just adding the sibling operand to the existing Service operation (which led to an object that should have been const being changed), now a new Service operation that includes the sibling is created. In particular, this fixes https://qlever.cs.uni-freiburg.de/osm-planet, which worked before #1341 and now works again as it should.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.64%. Comparing base (0ae5ce1) to head (242c3ff).
Report is 5 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1422      +/-   ##
==========================================
+ Coverage   89.38%   89.64%   +0.26%     
==========================================
  Files         340      343       +3     
  Lines       29727    29948     +221     
  Branches     3309     3314       +5     
==========================================
+ Hits        26570    26846     +276     
+ Misses       1999     1957      -42     
+ Partials     1158     1145      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hannahbast]

1-1 with Johannes, thanks a lot for the fix, minor changes

[hannahbast]

Awesome!

[sonarcloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud