-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix query planning for join with SERVICE
clause
#1422
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1422 +/- ##
==========================================
+ Coverage 89.38% 89.64% +0.26%
==========================================
Files 340 343 +3
Lines 29727 29948 +221
Branches 3309 3314 +5
==========================================
+ Hits 26570 26846 +276
+ Misses 1999 1957 -42
+ Partials 1158 1145 -13 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1-1 with Johannes, thanks a lot for the fix, minor changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
SERVICE
clauses
SERVICE
clausesSERVICE
clauses
Quality Gate passedIssues Measures |
SERVICE
clausesSERVICE
clause
There is a bug in the optimization introduced by #1341, which checks whether the sibling operand of a join with a
SERVICE
operations has a small result (and if yes, passes that result to theSERVICE
clause asVALUES
in order to reduce the result size of theSERVICE
call). Instead of just adding the sibling operand to the existingService
operation (which led to an object that should have beenconst
being changed), now a newService
operation that includes the sibling is created. In particular, this fixes https://qlever.cs.uni-freiburg.de/osm-planet, which worked before #1341 and now works again as it should.