Correct STRLEN function for UTF-8 multibyte characters
#1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joka921
approved these changes
Oct 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1584 +/- ##
==========================================
+ Coverage 88.97% 89.10% +0.13%
==========================================
Files 368 371 +3
Lines 33819 34462 +643
Branches 3826 3899 +73
==========================================
+ Hits 30090 30708 +618
- Misses 2473 2482 +9
- Partials 1256 1272 +16 ☔ View full report in Codecov by Sentry. |
joka921
requested changes
Oct 28, 2024
Co-authored-by: Johannes Kalmbach <[email protected]>
Co-authored-by: Johannes Kalmbach <[email protected]>
Conformance check passed ✅Test Status Changes 📊
|
joka921
changed the title
STRLEN function for UTF-8 multibyte characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
STRLENfunction now correctly counts the number of UTF codepoints in the Input (previously: The number of bytes in the UTF-8 serialization). So for exampleSTRLEN("Bäh") now correctly returns3`.