Lazy TransitivePath operation
#1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1595 +/- ##
==========================================
+ Coverage 89.08% 89.11% +0.02%
==========================================
Files 371 371
Lines 34437 34491 +54
Branches 3899 3908 +9
==========================================
+ Hits 30678 30735 +57
+ Misses 2484 2478 -6
- Partials 1275 1278 +3 ☔ View full report in Codecov by Sentry. |
RobinTF
commented
Oct 30, 2024
joka921
requested changes
Oct 30, 2024
joka921
requested changes
Oct 31, 2024
Conformance check passed ✅No test result changes. |
|
ullingerc
pushed a commit
to ullingerc/qlever
that referenced
this pull request
Nov 12, 2024
This PR enables the `TransitivePath` operation to yield its result lazily and to consume its left/right child lazily. Note that the graph which is transitively traversed needs to be fully materialized due to the underlying algorithm. E.G when computing the (large) result of `wdt:P31/wdt:P279*`, the large result and the `wdt:P31` can be dealt with lazily, but the full `wdt:P279` predicate needs to be materialized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the
TransitivePathoperation to yield its result lazily and to consume its left/right child lazily. Note that the graph which is transitively traversed needs to be fully materialized due to the underlying algorithm. E.G when computing the (large) result ofwdt:P31/wdt:P279*, the large result and thewdt:P31can be dealt with lazily, but the fullwdt:P279predicate needs to be materialized.