Add parameter to set delay time in readPicture() #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philrittenhouse
commented
Jul 11, 2024
|
|
||
| if (!runCommand(VC0706_READ_FBUF, args, sizeof(args), 5, false)) | ||
| { | ||
| Serial.println("VC0706: Read fbuf failed - delay time too small?"); |
There was a problem hiding this comment.
This is the error condition that the code hits when the delay time is too small, so let the user know what the possible cause is.
| @@ -79,7 +79,7 @@ class Adafruit_VC0706 { | |||
| boolean TVon(void); | |||
| boolean TVoff(void); | |||
| boolean takePicture(void); | |||
| uint8_t *readPicture(uint8_t n); | |||
| uint8_t *readPicture(uint8_t n, uint32_t delay_time = CAMERADELAY); | |||
There was a problem hiding this comment.
Use CAMERADELAY as the default so that everything works normally if no delay_time value is given.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change relates to issue #21. I saw a similar issue where it was necessary to increase the CAMERADELAY value from 10 to 32 in order to successfully read data from the cameras.
Following taf2's suggestion, this pull request adds a parameter to the readPicture() function to allow overriding the default CAMERADELAY value. By default the code will work as before using the CAMERADELAY value of 10. I have also added an error message to help users identify when increasing the delay time may be required.
I haven't been able to find a root cause for why increasing the delay time is sometimes necessary but it has helped in my setup and may help others.
I have tested the changes with my setup (ESP32 and two VC0706 cameras).
Best regards,
Phil