-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyproject.toml migration #148
base: master
Are you sure you want to change the base?
Conversation
30e3fc9
to
3466ffd
Compare
3466ffd
to
4940af1
Compare
Alright, this passes my copy of GitHub Actions on the local repo |
@brentru are the secrets up to date for this repository? It's failing pretty much all the unittests despite passing locally as well as in my fork with my credentials. |
Actually, I think it's because secrets aren't available to non-authorized users in PRs, I ran into this for Adabot PRs. |
@tekktrik I'm ok cleaning up the user access on this, could you email me/discord me what permissions need to be set in order for you to complete this migration? |
Sure! |
@tekktrik Could you take another look at this PR? I am not sure what it needs exactly. |
I'll try to take another look within the next couple weeks. I put things down for a few months and am picking back up now. |
I'll resolve the merge conflicts and update a few things this weekend and give it another shot. I can send you what I think is needed in a list here or Discord if you prefer. |
Resubmitting the same changes (plus a minor few extra) from #145, with the idea I'll follow through on getting it to pass CI as necessary (though I can't see the old logs anymore so this first one might just be to see what's still left):
Changes for migrating from
setup.py
topyproject.toml
. Changes include:setup.py
topyproject.toml
ez_setup.py
becausepyproject.toml
handles downloading build dependencies (setuptools
)ez_setup
as a moduleResolves #143