-
Notifications
You must be signed in to change notification settings - Fork 792
Fix LED array initialization in setup function #3175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changes per user feedback and https://github.com/fastled/fastled/wiki/basic-usage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR attempts to simplify the FastLED initialization by changing from a 4-parameter to a 3-parameter form of addLeds, based on the FastLED wiki's basic usage documentation. However, this change introduces a critical bug.
Key Changes:
- Modified
FastLED.addLedscalls to use 3-parameter form instead of 4-parameter form - Added a reference comment to FastLED wiki documentation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Changed to three arguments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Changes per user feedback and https://github.com/fastled/fastled/wiki/basic-usage