Fix hangs when transfer errors occur #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hathach
approved these changes
Sep 5, 2024
Member
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
superb!! Thank you very much for the fix to make driver more robust. I clean up the format a bit due to spaces vs tab. Will merge when ci passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes hangs that can occur with certain I2C devices. These where observed in a weather station running a Metro M4 Express. It uses a number of I2C sensors including HM3301 particle monitors (with 29 byte responses) and a PCA9615 bus extender. I was having hangs about once a day. Using the Watch Dog Timer, I was able to locate places where the code was not check for other error conditions while waiting for the SERCOM I2C controller. These fixes have eliminated these hangs.