Update zh_Latn_pinyin.py #7913
Merged
Update zh_Latn_pinyin.py #7913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Question: Is Chinese character not supported? Only US-ASCII encoding strings? |
|
The strings are UTF-8 encoded. We could have a chinese character translation if you like. We would disable the terminal on displays because of the many characters needed in the font. |
|
@tannewt could you approve my pr? |
|
Did you make it directly? Usually we get translation updates through weblate. |
|
yeah I made the changes directly |
|
Ok, I'll merge when the CI is done. Weblate is preferred I think because it keeps a newer copy of translations potentially. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added missing string translation for Chinese PinYin #1098