This repository has been archived by the owner on Feb 10, 2023. It is now read-only.
Islandora 2423 #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually use the constant =)
Add fcrepo 3.8.1 support. Address ISLANDORA-1149
Change to Sparql.
Hitting ISLANDORA-1610 ISLANDORA-1577 and ISLANDORA-1570
sites/all/modules/islandora_oai/islandora_oai.install: +222: [minor] Function comment short description must end with a full stop +225: [minor] Line indented incorrectly; expected 2 spaces, found 0 +227: [minor] A comma should follow the last multiline array item. Found: 'http://www.ndltd.org/standards/metadata/etdms/1-0/etdms.xsd'
+222: [minor] Function comment short description must end with a full stop
Fixes for ISLANDORA-1613
… setup issue templates for each Islandora Foundation module.
Address ISLANDORA-1616; Take avantage of new GitHub functionality and…
Solr query backend
Adding the words, "data provider" to distinguish that this is not a "harvester". Also correcting spelling of islandora_oa in description.
Use POST for membership queries as the filters can be overly large.
ISLANDORA-1869
When we look for sets within sets we only look for active objects, but when just doing a normal listsets we respond with inactive sets.
Make listsets only respond with active collections
grandfathered in. However, this isn't the case for forks.
7.x islandora oai 1880
ISLANDORA-1698 - Update CONTRIBUTING.md
ISLANDORA-2053: Update travis.yml to force PHP 5.3.3 to run under Ubuntu Precise
Work on ISLANDORA-2120.
ISLANDORA-2234: Add support for oai_qdc metadata format
Fix ISLANDORA-2289 add context for resumptionToken.
* Remove base filters before building query. * Add toggle and isolate remove base filters
Make metadataPrefix queries case sensitive
ISLANDORA-2321: Make sure islandora_solr utilities.inc is available in scope.
ISLANDORA-2349 changes to pull request template
- added extra checking if variables are arrays to avoid count() errors Resolves: https://jira.duraspace.org/projects/ISLANDORA/issues/ISLANDORA-2423
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does this Pull Request do?
Adds extra type checking for the existance of arrays before calls to count() using NULL
Whats new?
using is_array() to check if a variable is an array before using count() and extra return calls if the variable
is NULL
How should this be tested?
Generate tests that don't return an error array, no error messages about count() should be generated
Interested Parties
@nhart