-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supabase hook cleanup/Cleaner Index #17
Merged
adamcohenhillel
merged 12 commits into
adamcohenhillel:main
from
Jacksonmills:supabase-hook-cleanup
Feb 12, 2024
Merged
Supabase hook cleanup/Cleaner Index #17
adamcohenhillel
merged 12 commits into
adamcohenhillel:main
from
Jacksonmills:supabase-hook-cleanup
Feb 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimized authentication flow by removing redundant loggedIn state in favor of direct checks using user and supabaseClient. Updated useSupabase hook to manage auth state changes and improved type definitions for clarity and type safety in useSupabaseConfig utility functions.
Implemented a visual LoadingSpinner component and integrated it into the main page to improve user experience during initial session checking. Now, the page displays a loading spinner until the Supabase session status is verified, enhancing feedback during asynchronous operations. Also included is the sessionChecked state to reliably track the completion of the session check. This change prevents the app from prematurely displaying login or chat components before the session state is determined. Refactored useSupabase hook to handle session checking and state updates more effectively, ensuring that the user interface accurately reflects the current authentication state.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adamcohenhillel
changed the title
Supabase hook cleanup/Better logged in loading state
[WIP] Supabase hook cleanup/Better logged in loading state
Feb 6, 2024
Need to wait for this? #19 |
We could, but this is done in that I only really meant to fix the 'any' in the supabase hook in the ticket |
Jacksonmills
changed the title
[WIP] Supabase hook cleanup/Better logged in loading state
Supabase hook cleanup/Cleaner Index
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.