Use file.readinto instead of np.fromfile when reading data #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to avoid poor performance of np.fromfile, see numpy/numpy#13319
adamreeve
force-pushed
the
fromfile_perf
branch
from
090ed79
to
9e472c0
Compare
Codecov Report
@@ Coverage Diff @@
## master #256 +/- ##
=======================================
Coverage 96.97% 96.98%
=======================================
Files 19 19
Lines 2478 2485 +7
=======================================
+ Hits 2403 2410 +7
Misses 75 75
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid poor performance of
np.fromfilein Python 3, and should help with #249