Request for adding some more options to widget#6
Open
edward-jazzhands wants to merge 7 commits intoadamviola:mainfrom
Open
Request for adding some more options to widget#6edward-jazzhands wants to merge 7 commits intoadamviola:mainfrom
edward-jazzhands wants to merge 7 commits intoadamviola:mainfrom
Conversation
min_zoom: int, max_zoom: int, and nested: bool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, loving the widget. First off want to thank you a lot for making this.
During my usage I've found that I encountered two problems:
I made additions to solve both these problems and I tried to make sure it maintains backwards compatibility. The new arguments have defaults that follow the previous behavior (except for setting a default zoom out limit), so it shouldn't affect anyone using it unless they opt in.
Let me know what you think! I can see the last time you updated this was two years ago so hopefully you're still around. I have it working inside my own program so I could demonstrate how it fixes the 'nested' problem, or anything else you might want to discuss.