Fix: Recover from unresolvable _start ids on import#221
Merged
Conversation
When a course's _start._startIds references content not present in the import, the StartPage transform previously left the dangling id in place, producing a course that loads indefinitely (the player cannot find a start page). Recover gracefully: if the course has exactly one page, default the start to it; otherwise remove the _start config so the menu loads. A warning is logged in both cases and resolvable start ids are unchanged.
|
🎉 This PR is included in version 3.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #220
Fix
_start._startIds[]._idreferences content missing from the import, theStartPagetransform previously logged a warning and left the dangling id in place, producing a course that loads indefinitely (the player can't find a start page)._friendlyId, generating one if absent)._startconfig so the course loads its menu.Testing
tests/migrations.spec.js: single-page fallback, generated-_friendlyIdfallback, and_startremoval when not exactly one page.standardclean.Note