Fix: Resolve import globs safely on Windows paths#225
Merged
Conversation
|
🎉 This PR is included in version 3.4.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
AdaptFrameworkImportbuilt several glob patterns by interpolating a filesystem path (this.path/this.langPath) directly into the pattern string. On Windows the\separators are interpreted as glob escape characters (and any glob-significant character in the path —[,(,*— breaks matching on every platform), so course directories, assets and plugins fail to resolve during import. Each path is now passed via thecwdoption with a relative forward-slash pattern andabsolute: true, posix: true(consistent with this file's/-based path handling and the already-safecwdglobs elsewhere in it).prepare()— course directory discoveryloadAssetData()— asset metadata and manual asset listingloadPluginData()— used content pluginsimportCourseAssets()— asset file lookupTesting
loadAssetData()test that drives the method with a course path containing glob-significant characters ([id]); it fails without the fix on all platforms.