Fix: repair import progress hook and emit stable stage ids#227
Merged
Conversation
- Forward the progress payload in the module hook bridge; it was passing the importer instance, which the websocket relay serialised into an infinite loop (Maximum call stack size exceeded).
- Emit { id, labelKey } stage descriptors from the import loop instead of raw method names + step counts, and drop the redundant per-item progress events.
|
🎉 This PR is included in version 3.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #226
Fix
importProgressHookbridge; it was passing the importer instance, which the websocket relay serialised into an infinite loop (Maximum call stack size exceeded).Update
{ id, labelKey }stage descriptors from the import loop instead of raw method names + step counts, so consumers render progress without hard-coding the phase list.Testing