Fix: Resolve default-routes.json path via fileURLToPath (fixes #107) - #112
Merged
Conversation
|
🎉 This PR is included in version 4.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #107
Fix
default-routes.jsontemplate path withfileURLToPath()instead ofnew URL(...).pathname. On Windows,URL.prototype.pathnamereturns a value like/C:/path/...(leading slash before the drive letter), which is not a valid path when passed on toreadJson/fs.readFile; it also percent-encodes characters such as spaces and#.fileURLToPathhandles drive letters, UNC paths, and decoding correctly on all platforms.resolveModulePath(relativePath, baseUrl)util (barrel-exported fromlib/utils.js) so it is unit-testable.Testing
tests/utils-resolveModulePath.spec.js: resolves a relative path against a module URL, decodes percent-encoded characters thatURL.pathnameleaves escaped (asserting divergence from.pathname), and reads a real file from disk. This exercises the same class of bug on POSIX CI (via percent-encoding), which the Windows-only drive-letter symptom otherwise hides.npx standardpasses on the changed files.