Fix: Delegate block tracking ID assignment to spoortracking#119
Merged
Conversation
clone() no longer pre-allocates _trackingId; cloned block payloads are assigned IDs by content's preInsertHook (tapped by the spoortracking module), so the content module holds no tracking-ID logic. Requires the matching spoortracking release. Refs cgkineo/adapt-authoring#201
|
🎉 This PR is included in version 3.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #118
Fix
_trackingIdpre-allocation and the per-payload override fromclone(). Tracking IDs are now owned entirely byadapt-authoring-spoortracking, which assigns them via content'spreInsertHook(fired once per clone payload). The content module no longer references_trackingId.Breaking
Testing
preInsertHookfires per cloned payload andclone()assigns no IDs itself. 131/131 pass;standardclean.