Closed
New: Move route definitions to routes.json (fixes #47)#48
Conversation
Co-authored-by: taylortom <1059083+taylortom@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor route definitions to use routes.json
Refactor(roles): move route definitions to routes.json
Feb 26, 2026
taylortom
marked this pull request as ready for review
February 26, 2026 17:44
Contributor
|
Closing in favour of #49 which will include these changes with fixes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route configuration is moving from imperative code to declarative
routes.jsonfiles, consumed byloadRouteConfiginadapt-authoring-server. SinceRolesModuleonly uses default CRUD routes, the entire route setup reduces to a single JSON file.Update
this.root = 'roles'assignment andthis.useDefaultRouteConfig()call insetValues()with aroutes.jsonat the module root —loadRouteConfignow handles route registration automaticallyNew
routes.jsondeclaring"root": "roles"— noroutesarray needed since all routes are inherited fromAbstractApiModuledefaultsTesting
npm test— all 47 tests pass/api/rolesas beforeOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.