Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #109
Fix
The "Retry Assessment" button called the assessment reset without forcing it. When the results component sits on a different page from the assessment, the assessment's reset bails out (it is already complete in the session and not set to reset on revisit), so the click did nothing. This was most visible with "Allow retry once passed" (
_allowResetIfPassed) enabled, since that is what makes the button appear after passing.The retry click is an explicit, user-initiated reset and is already gated by the button's enabled state (retry allowed, attempts remaining), so it now forces the reset. Resetting on page revisit is unaffected, so
_allowResetIfPassedon its own still resets only via the button, not automatically on revisit.Testing
_allowResetIfPassed) enabled and infinite attempts._routeToAssessmentenabled.Posted via collaboration with Claude Code