Skip to content

Fix: repair v5.7.0 to v5.8.0 migration (fix #123) - #126

Open
swashbuck wants to merge 1 commit into
masterfrom
issue/123
Open

Fix: repair v5.7.0 to v5.8.0 migration (fix #123)#126
swashbuck wants to merge 1 commit into
masterfrom
issue/123

Conversation

@swashbuck

Copy link
Copy Markdown
Contributor

Fixes #123

Bug 1: confidenceSliders never populated

The 5.7.0 to 5.8.0 block declared let confidenceSliders but had no whereContent callback to assign it, so the first mutateContent threw TypeError: Cannot read properties of undefined (reading 'forEach').

Added the standard whereContent block used elsewhere in the file to populate it via getComponents('confidenceSlider').

Bug 2: checks compared to null after delete

The mutate steps delete confidenceSlider._x, making _x undefined, not null. The four checkContent callbacks compared to null and so always reported the property still present.

Changed each check to !_.has(confidenceSlider, '_x'), mirroring the _.has(...) guard in the mutate steps.

Posted via collaboration with Claude Code

Add missing whereContent block to populate confidenceSliders, fixing
TypeError on forEach. Change the four checkContent callbacks to use
!_.has(confidenceSlider, '_x') instead of comparing to null, since the
mutate steps delete the property (making it undefined, not null).

Fixes #123

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@swashbuck swashbuck self-assigned this Jun 23, 2026
@swashbuck swashbuck moved this from New to Needs Reviewing in adapt_framework: The TODO Board Jun 23, 2026
@swashbuck
swashbuck requested a review from taylortom June 23, 2026 20:50
@swashbuck swashbuck changed the title Fix: repair v5.7.0 to v5.8.0 migration Fix: repair v5.7.0 to v5.8.0 migration (fix #123) Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Needs Reviewing

Development

Successfully merging this pull request may close these issues.

Migration v5.7.0 → v5.8.0 cannot run cleanly (TypeError + faulty checks)

3 participants